Remove unnecessary loop variable from series meta-programming #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1923 +/- ##
==========================================
+ Coverage 87.39% 87.41% +0.02%
==========================================
Files 97 97
Lines 35614 35614
==========================================
+ Hits 31124 31132 +8
+ Misses 4490 4482 -8 ☔ View full report in Codecov by Sentry. |
fingolfin
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop variables in question are the same for all iterations, making it possible to instead inline them.
Inlining makes everything a lot more readable (at least for me). Furthermore, it enables us to
grepfor some flint function and find all places where it is called (of course if all similar places are inlined/unrolled as well).